Subject: Win32 PageSetup question and unrelated patches
jeremyd@computer.org
Date: Thu Aug 30 2001 - 12:59:15 CDT
Below in the _onNotifyTab as currently defined,
on case UDN_DELTAPOS: it does not specify
a return value - ie shouldn't the break be return 0?
I only glanced at the source, so maybe it should be return 1.
I am just fixing the compile error it causes (not all control
paths return a value) so I thought maybe someone on this list
knows the correct return value.
Once again, please forgive me if this is already fixed
(I am using cvs source from a few hours ago).
[Method as defined in ap_Win32Dialog_PageSetup.cpp]
BOOL AP_Win32Dialog_PageSetup::_onNotifyTab(HWND hWnd, LPARAM lParam)
{
// This handles WM_NOTIFY message for all of the sub-dialogs.
LPNMUPDOWN lpnmud = (LPNMUPDOWN)lParam;
switch( lpnmud->hdr.code )
{
case UDN_DELTAPOS:
doSpinControl( lpnmud->hdr.idFrom, -lpnmud->iDelta );
break;
default:
UT_DEBUGMSG(("WM_Nofify for id %ld for sub-dialog\n", lpnmud->hdr.code));
return 0;
}
}
[End method]
I have also attached some patches to xap_Win32Frame and ap_Win32Frame.
They basically change the current behaviour of opening abiword
using system default size & location and provide the application
a chance to specify a size - which ap_Win32Frame then does
(taking into account the actual screen size available). The change
is that now AbiWord opens and doesn't have to be resized to see
the full width of the document (or opens to nearly full screen on
lower resolutions). The patches are included in the zip below
(hopefully no one minds the attachement - its only 2.6KB), I'm not
sure the proper format, so I just ran diff -u on the changed files
and then zipped them. Feel free to use/ignore/alter them as you
see fit.
Thank you,
Jeremy Davis
jeremyd@computer.org
This archive was generated by hypermail 2b25 : Thu Aug 30 2001 - 16:00:15 CDT