Subject: fv_View.cpp commit
From: Thomas Fletcher (thomasf@qnx.com)
Date: Mon Jan 01 2001 - 19:31:43 CST
I have a question that goes along with this fix. I noticed that
most of the placesin fv_View.cpp where we are calling
_ensureThatInsertionPointIsOnScreen() we do something like the
following:
if (!_ensureThatInsertionPointIsOnScreen()) {
_fixInsertionPointCoords();
_drawInsertionPoint();
}
But then in the body of _ensureThatInsertionPointIsOnScreen() we
have the code:
if(bRet == UT_FALSE) {
_fixInsertionPointCoords();
_drawInsertionPoint();
}
return bRet;
Is there a reason why we couldn't clean up all the view code
to just plain old call _ensure...OnScreen() without the tests
and duplicated calls?
Thomas
---Fixes to address problems described in:
http://www.abisource.com/mailinglists/abiword-dev/00/September/0095.html
Where the document window would shift and move under your feet when you performed operations such as replacing a mis-spelled word or selecting the spelling dialog on an empty document. CVS: ---------------------------------------------------------------------- CVS: Enter Log. Lines beginning with `CVS:' are removed automatically CVS: CVS: Committing in . CVS: CVS: Modified Files: CVS: fv_View.cpp CVS: ----------------------------------------------------------------------
This archive was generated by hypermail 2b25 : Mon Jan 01 2001 - 19:33:17 CST