Subject: Re: About makewrapper.sh
From: Vlad Harchev (hvv@hippo.ru)
Date: Tue Jan 02 2001 - 09:06:18 CST
On Tue, 2 Jan 2001, Jing-Tang Keith Jang wrote:
Yes, this patch looks fine. Thank you very much for it. I will manage to
properly integrate it into the tree and other scripts soon.
> On 12/27/00, Vlad Harchev wrote:
> > I think the solution is to put a file named '.already-in-fp' into the subdirs
> > of $Abi/fonts/ that shouldn't be added to fontpath explicitly, and tweaking
> > the scripts that generate 'AbiWord' script so 'AbiWord' script doesn't add
> > dirs with file named '.already-in-fp' in them to fontpath. I.e., the font
> > packager should add file '.already-in-fp' to the '$Abi/fonts/Big5/' (that's
> > true for all CJK fonts I assume).
>
> I've modified makewrapper.sh to use the .already-in-fp cookie, and
> the following extended LANG logic. Could you please review the
> attached diff? The rest three script could be modified in the same
> way, but I'm not sure how to "unite" them as a single script.
>
> Thanks for the help.
>
> > Note: there are FOUR scripts that generate 'AbiWord' script:
> > src/pkg/common/unix/data/t[gb]z_install.sh
> > src/pkg/common/unix/scripts/makewrapper.sh
> > src/pkg/linux/deb/AbiWord
> > Each of them should be modified or made calling some intermediate script
> > (makewrapper.sh?).
> >
> > Also, the logic of each script should be further extended - for
> > LANG=ru_RU.KOI8-R AW looks in the following subdirectories of the
> > ${prefix}/fonts/ for additional fonts:
> > ru
> > KOI8-R
> > ru-RU
> > ru-RU.KOI8-R
> > , but 'AbiWord' script generated by the current version of the makewrapper.sh
> > looks only for a directory named 'KOI8-R'.
> >
> > So, the scripts should construct a list of allowed subdirectories based on
> > the same rules as AW, checking whether '.already-in-fp' exists in each of
> > them, and add all approved subdirectories to font path.
> > But I think that only a single script should be generating 'AbiWord' script
> > to simplify maintanence, so this should be hacked first. Could someone please
> > do it?
> >
>
> --
> Keep it simple AND stupid.
>
Best regards,
-Vlad
This archive was generated by hypermail 2b25 : Tue Jan 02 2001 - 09:38:06 CST