Subject: Re: BiDi patch
From: Tomas Frydrych (tomas@frydrych.uklinux.net)
Date: Sat Jan 13 2001 - 09:49:59 CST
Hi Martin,
> I just tried this. Firstly I note that there a ton of gint8,
> gboolean etc definitions throughout the patch. Does the mini-glib we have
> work for Windows and and other OS's for this patch?
>
The g-types are not 'real', they are redefined by macros to our UT_
types, and only appear in the FriBiDi headers. The reason I choose
this approach is future maintainance; the Unicode tables from the
FriBiDi library may need to be updated time from time and this
way, the files can just be replaced without modification.
> Next I randomly selected a not too difficult word doc I have. You patch
> fails to render this correctly. Many text runs are reversed.
There are two issues here. (1) the patch currently implements only
the the core changes, and thus works only with the ABW native
format; the importers/exporters will have to be modified to handle
the two new properties called 'direction' and 'dominant-direction'. (2)
The last patch I made was in test mode in which capitals are
treated as RTL characters; this was an oversight, to fix it just
comment out #define CAPS_TEST near the top of fp_TextRun.cpp
and recompile, hopefully you should see your doc OK. (I should
say that only the first character of each run is tested, since runs of
different direction cannot be coalesced, so that you almost
certainly see even lowercase characters reversed in your document
in the test mode.)
Tomas
*********************************************
tomas@frydrych.net / www.frydrych.net
PGP keys: http://www.frydrych.net/contact.html
This archive was generated by hypermail 2b25 : Sat Jan 13 2001 - 09:55:55 CST