patch for bug 633


Subject: patch for bug 633
From: Sam TH (sam@uchicago.edu)
Date: Thu Jan 25 2001 - 02:57:19 CST


This patch should fix bug 633 (select all in docs with footers
segfaults) but I'd like to make sure it doesn't break stuff for other
people.

Index: src/text//fmt/xp/fv_View.cpp
===================================================================
RCS file: /cvsroot/abi/src/text/fmt/xp/fv_View.cpp,v
retrieving revision 1.347
diff -u -r1.347 fv_View.cpp
--- src/text//fmt/xp/fv_View.cpp 2001/01/21 23:03:31 1.347
+++ src/text//fmt/xp/fv_View.cpp 2001/01/25 08:57:20
@@ -4800,7 +4800,7 @@
         UT_Bool bIsDirty = UT_FALSE;
         fp_Run* pCurRun = pRun1;
 
- while (!bDone || bIsDirty)
+ while ((!bDone || bIsDirty) && pCurRun)
         {
                 if (pCurRun == pRun2)
                 {
@@ -4923,6 +4923,10 @@
                         {
                                 pCurRun = pNextBlock->getFirstRun();
                         }
+ else
+ bDone = UT_TRUE;
+ // otherwise we get fun
+ // infinte loops
                 }
         }
 }

           
        sam th
        sam@uchicago.edu
        http://www.abisource.com/~sam/
        GnuPG Key:
        http://www.abisource.com/~sam/key




This archive was generated by hypermail 2b25 : Thu Jan 25 2001 - 02:58:28 CST