Subject: Re: My first patch...
From: Sam TH (sam@uchicago.edu)
Date: Mon Jan 29 2001 - 18:55:26 CST
On Mon, Jan 29, 2001 at 07:50:47PM -0500, Leonard Rosenthol wrote:
> ..and it's easy enough that I'm going to describe it rather than send
> a .diff file (well that and I don't have cygwin installed ;).
>
> File: "abi/src/wp/impexp/xp/ie_imp_AbiWord_1.cpp"
> Line: 224
> Add a {
>
> Line: 233
> Add a }
You don't really mean 233 here, do you? That's the middle of the next
case. What you want is to change
return;
case TT_BLOCK:
224: X_VerifyParseState(_PS_Sec);
m_parseState = _PS_Block;
X_CheckError(m_pDocument->appendStrux(PTX_Block,atts));
return;
228:
case TT_INLINE:
to
return;
case TT_BLOCK:
224: {
X_VerifyParseState(_PS_Sec);
m_parseState = _PS_Block;
X_CheckError(m_pDocument->appendStrux(PTX_Block,atts));
return;
228: }
case TT_INLINE:
right?
>
> (in other words, bracket the TT_BLOCK case block)
>
> Why, because some compilers don't like the fact that you are defining
> a variable inside of a single case of a switch, unless that case is
> separately scoped.
sam th
sam@uchicago.edu
http://www.abisource.com/~sam/
GnuPG Key:
http://www.abisource.com/~sam/key
This archive was generated by hypermail 2b25 : Mon Jan 29 2001 - 18:55:51 CST