Subject: commit: Re: Page setup dialog
From: Mike Nordell (tamlin@algonet.se)
Date: Tue Jan 30 2001 - 21:12:15 CST
wrote:
> Please fix this "bug" as you call it in XP-land an in the Windows impl. I
> promise to fix the Unix dialog as soon as you check in your changes.
Thanks. And... done.
wp/ap/xp/ap_Dialog_PageSetup.*
wp/ap/win/ap_Win32Dialog_PageSetup.cpp
wp/ap/win/Makefile (I hope I got this one right)
fmt/xp/fp_PageSize.*
and some MSVC6 project files are yet again updated to include the page setup
dialog files.
There are some issues left. Such as:
- Is it really usable to be able to have different units for the page and
its margins (i.e. the m_MarginUnits member)? It seems wierd to me to e.g.
specify the page in mm and the margin in inch.
- I changed internal members from the type UT_Dimension to fp_PageSize::Unit
since it makes no sense setting a page unit to PI (3.14...?) or percent, we
need absolute values. Would you also consider this a correct decision?
- Should we perhaps change this to support two (mutually exclusive) ways of
specifying
pagesize, either by absolute x/y size or as predefined pagesize (Legal,
Letter, A4 ...)? Currently we don't support the latter.
/Mike
This archive was generated by hypermail 2b25 : Tue Jan 30 2001 - 21:12:07 CST