Subject: Re: Copyrights
From: Dom Lachowicz (dominicl@seas.upenn.edu)
Date: Sat Jun 09 2001 - 22:58:01 CDT
Quoting Mike Nordell <tamlin@algonet.se>:
> > And please fix src/af/util/win/ut_win_iconv.cpp - all it does is add a
> > useless stack frame.
>
> Why adding a "useless" stackframe? Are there stdcall/cdecl problems, or
> were
> it just "hysterical" resons? (sorry for not looking into this closer,
> I've
> simply too busy right now).
It's useless because all it does is this trivial marshalling, and then only on
win32, if this code is ever called at all:
UT_iconv (foo, bar) {
iconv(foo, bar);
}
> > If the file isn't used (and I don't see how it could be),
> > cvs remove it or actually make it use the code in the '#if 0' block.
>
> Removal seems more reasonable (if the whole file would be inside "#if
> 0"),
> or? :-)
> I hope I can have a look at it after I've checked in the (much modified)
> ut_iconv.cpp.
If there are issues with iconv and windows (which i don't think is the case,
considering Andrew's recent work), then there's a reason to keep these
functions around, provided that they do something useful. As it is now, they
are completely and utterly useless and should be pruned by someone with a win32
box :-)
Dom
This archive was generated by hypermail 2b25 : Sat Jun 09 2001 - 22:58:20 CDT