Subject: Re: TODO Before the release
From: Thomas Fletcher (thomasf@qnx.com)
Date: Thu Jun 14 2001 - 07:15:14 CDT
On Wed, 13 Jun 2001, Dom Lachowicz wrote:
> Hi Martin,
>
> > > 3) Make toolbar color buttons work on win32 and unix-non-gnome
> >
> > I don't mind the gtk-only not having these. If needed, this
> > functionality
> > can be provided via the "font" or "styles" dialog. See my reasoning on
> > gtk-only below. I have no great desire to reinvent wheels for
> > gtk-only. The gnome build is meant to be better than gtk-only anyway
> > since
> > it builds on a great platform of other people's work.
>
> Well, first off, thanks :) Secondly, this is unacceptable. I'll even do the
> code for this. We don't need to make it a drop-down widget. Popping up a
> GtkColorSel inside of a dialog when the button is pressed would suffice, IMHO.
> It'll take me 15 minutes. Win32 guys - connect a callback to the pressed signal
> on the button and do the same.
If you check the archives of the mailing list you should see that
this is exactly the solution I proposed for 0.7.14 when I forced
all platforms to at least have the button. This is the behaviour
on QNX which doesn't have a widget to do the drop down colour
selection (and I didn't have a chance to do the new one).
> > > 4) Clipart dialog
> > > - Dom: dload, checkin, and install clipart
> > > - Non-gnome platforms: actually code the dialog
> >
> > Dom, I've looked at your screen shot and thought about doing a GTK-only
> > dialog. Then I realized I would have to essentially rewrite gdk-pixbuf
> > to
> > make each clip art image scale to the right size to fit nicely on the
> > dialog.
> >
> > I have no intention of wasting my time to do this. The gtk-only build is
> > only for users without the diskspace or system requirements for the
> > beautiful gnome build.
> >
> > Given this, the clip-art dialog would default to look eactly like the
> > "insert image" dialog with the only difference being that the file
> > directory defaults to point to a clip-art directory that Abi knows about
> > although I do not yet.
>
> Ok, then disable this. I'm not a big fan of your decision, however. Scaling
> images is easy given our current codebase, and no we wouldn't have to rewrite
> GdkPixbuf to do accomplish this. See the image preview code in the OpenSaveAs
> dialog as an example. Either we:
>
> 1) Code it right
> 2) Disable it altogether for Unix
>
> I won't allow the insert-image dialog to double as the clipart dialog.
I have no real comment on this, not having yet seen the clipart dialog,
but if our XP Graphics class won't let us do this, then we should
consider a bit of refactoring to make that happen.
Thomas
This archive was generated by hypermail 2b25 : Thu Jun 14 2001 - 07:13:55 CDT