Subject: Re:[4] Win32 version dying on startup [fix maybe]
From: Michael D. Pritchett (mpritchett@attglobal.net)
Date: Thu Nov 08 2001 - 11:20:23 CST
On Thu, 8 Nov 2001, Kenneth J.Davis wrote:
> My first impressions are that some of the initialization for them is
> still behind an #ifdef DEBUG construct, but I haven't seen anything to
> confirm this. And perhaps they aren't supposed to be there yet, I'm
> just going on the fact the #ifdef DEBUG was removed from their ids.
>
> Ok looked some more and sure enough,
> MenuItem(AP_MENU_ID_INSERT_BOOKMARK)
> MenuItem(AP_MENU_ID_INSERT_HYPERLINK)
> were now now not protected by #ifdef DEBUG in ap_Menu_Layouts_MainMenu.h
> but in ap_Menu_ActionSet.cpp they were, so pAction was NULL causing
> the fault. I still need to do some verification (recompile with
> a clean tree in case I have some other changes in my trying/testing
> that are effecting this), but I believe removing the particular
> #ifdef DEBUG in ap_Menu_ActionSet.cpp will fix it. And if no one
> beats me to it, I will submit a patch once I verify it works in
> a clean tree (in a couple hours or so).
>
> Thank you,
> Jeremy Davis
> jeremyd@computer.org
>
Jeremy -
Great detective work. I thank you for the effort an time you put into it.
Dom you ap_Menu_ActionSet.cpp changes and I confirmed that this has fixed
the release build. That was definately a nasty bug to decipher.
Cheers!
Michael D. Pritchett
This archive was generated by hypermail 2b25 : Thu Nov 08 2001 - 11:30:49 CST