Subject: Re: commit: piecetable changes
From: John L. Clark (jlc6@po.cwru.edu)
Date: Sat Nov 10 2001 - 12:53:57 CST
On Sat, Nov 10, 2001 at 05:49:45PM -0000, Tomas Frydrych wrote:
> (1) when applying a style to something that already has a style, we
> first remove all attributes and properties associated with the old
> style and only then add the attributes and properties of the new
> style. In the past we simply applied the properties of the new style
> over all existing properties which meant that the result was not the
> formating of the new style but a union of all previously used styles.
Looking at the bug report, and the nature of this fix, does this remove
the need for the "Normal Clean" styles and that strategy of using
styles?
> These changes go some way toward fixing major bug 1939; there
> is one more issue that needs to be resolved, and on which I need
> Martin's input. Because the list-specific attributes are not part of
> the style definitions, applying say Normal style to a list style will
> not remove the numbering, etc. It would seem to me that the best
> thing would be to add function to the style class bool
> isNumbered(), which would return true for all the list styles,
> numbered headings, etc., and which could be used to determine
> whether to remove the list-specific attributes and related stuff.
One long standing question of mine was why list information should be
contained in a style at all. It seems to violate the standard
definition of a style, and I think it would make sense only as an
attribute of a paragraph, or - and this may just be my html background
speaking - as a separate element structure altogether. I think the
latter would be better. I could make an argument to this effect, if it
would be desirable. As it seems to be a long-established fact of our
document structure, though, I would initially just be curious to know
the motivation behind the decision.
Take care,
John
... whose conference is almost over, and would /really/ like to get
back to hacking on Abi ...
This archive was generated by hypermail 2b25 : Sat Nov 10 2001 - 12:53:50 CST