Subject: Re: commit: piecetable changes
From: Martin Sevior (msevior@mccubbin.ph.unimelb.edu.au)
Date: Sun Nov 11 2001 - 01:26:04 CST
On Sun, 11 Nov 2001, Matti Picus wrote:
> Currently the paragraph style holds a dummy attribute called "list-decimal"
> that basically provides the functionality you describe. Its value is never
> used within list label creation, but somehow its presence enables undo
> functionality to work properly.
Matti,
Sorry for the confusion on this issue. I'll try to explain again.
1. "list-decimal" *IS* used in theory. It does something. It defines extra
characters that are placed between list labels for nested lists.
2. All the list attributes and properties that are used to define a style,
like listId, parentID, start-value, list-style, list-delim and
list-decimal have to be recorded in piecetable attributes/properties for
every paragraph in order for undo to work correctly.
If you can find a way to do away with list-decimal and still get the same
effects, feel free to do so. In my emails to you I just wanted to
emphasize that all properties actually used in list definitions have to
stay in the document in order to get undo to work properly.
>
> I propose that someone (I wanted to do it, but real work is getting in the
> way) replace it with a "list-style" attribute, whose value is one of a
> limited number of list styles for the document (bullet, single level
> numbering, multi-level numbering) and a "list-level" attribute, whose value
> indicates a level of nesting of the list item, which corresponds to a
> particular indent and label formatting scheme.
>
We have a list-style property already.
We don't need a list-level. It can be calculated by the number of
parentID's in the paragraph's parentage.
The indent points of a list is given by the already existing paragraph
properties.
I hope this clears up these misunderstandings.
Cheers
Martin
This archive was generated by hypermail 2b25 : Sun Nov 11 2001 - 01:26:18 CST