Subject: fix
From: Kenneth J.Davis (jeremyd@computer.org)
Date: Thu Nov 22 2001 - 19:56:34 CST
The file tb_edit_editfooter.xpm has the wrong count for number of
colors, which results in my VC5 builds dying on startup (cvs from
earlier and 0.9.5 source tarball). The attached patch corrects it
to be 42, the actual number of colors defined in the file.
Alternatively, someone could add
". c #00FF00",
which is not used, but defined in edit_editheader.xpm (which actually
has 43 colors, but doesn't use it either)
Also, could someone explain to me why in ut_Xpm2Bmp.cpp there is a line
UT_uint32 nf = sscanf(...
when
int sscanf(... "The sscanf function returns the value of the macro EOF if
an input failure occurs before any conversion."
and
"EOF which expands to an integer constant expression, with type int and a negative value"
so nf returns a negative value on errors (which of course should not
occur, but does in cases such as an xpm file with the wrong value for
number of colors) which is incorrectly converted to an unsigned value.
Thanks
Jeremy Davis
jeremyd@computer.org
This archive was generated by hypermail 2b25 : Thu Nov 22 2001 - 19:57:28 CST