Subject: Re: Bugs in fp_line::Layout.cpp (was) Re: Paragraph re-draw problem
From: Martin Sevior (msevior@mccubbin.ph.unimelb.edu.au)
Date: Fri Oct 19 2001 - 02:52:57 CDT
On Fri, 19 Oct 2001, Tomas Frydrych wrote:
>
>
> Hi Martin,
>
> > 1. With the new code if you set "full justification" from a paragraph that
> > was previously left justfied it doesn't immediately jump to full
> > justification. Instead it jumps to full justification on next key press.
> I recall you mentioned this before, but I was not able to reproduce
> this behaviour. I have got here a build from Oct 14th, which is well
> after the new layout function, and it does not have this problem,
> perhaps it affects only non-bidi build.
>
This may be so. It was non-bidi build.
> > 2. If you have a full justified paragraph followed by a left justified
> > paragraph and delete the paragraph break, the lines following the
> > paragraph break remain left justfied until you type something.
> I can reproduce this one.
>
> > Turning the old code back on fixes both these bugs.
> I agree we need to fix these bugs, but turning the old code back on
> is not a solution, the old code is fundamentally flawed (I have
> explained the problem before committing the changes).
>
I agree. I didn't mean to say we should go back to the old code. I just
wanted to explain where the bugs are.
> > 3. Also a full justified paragraph flickers and redraws on every keypress
> > now. This is true for both the new and old layout code. AbiWord 0.9.4.1
> > did not have this.
> This happens in paragraph of any justification in my case.
>
> I will look into these, probably tomorrow.
>
Thanks Tomas,
Martin
This archive was generated by hypermail 2b25 : Fri Oct 19 2001 - 02:53:04 CDT