Subject: Some 0.9.4.1 bugs (and fixes)
From: Bernhard Rosenkraenzer (bero@redhat.de)
Date: Tue Oct 23 2001 - 10:52:07 CDT
Hi,
depending on the options you pass to make, 0.9.4.1 won't compile. All of
this is on Red Hat Linux 7.2, trying to build the plain gtk version.
It won't compile at all with standards-enforcing compilers (void * vs.
const void * issue, fixed by attachment #1).
It doesn't compile with ABI_OPT_LIBXML2 because it looks for the include
files in the wrong place (namely in libxml1's place). Fixed by attachment
#2.
Doesn't compile with ABI_OPT_STL because UT_Pair tries to inherit from
XAP_AbiObject, which doesn't exist. Fixed by attachment #3.
Doesn't compile with ABI_OPT_PLUGINS for a couple of reasons:
- ie_exp_AWT.cpp uses UT_ASSERT() without including ut_assert.h
- ie_exp_GZipAbiWord.cpp and ie_exp_KWord_1.cpp use ABI_PLUGIN_DECLARE
before including xap_Module.h
- missing semicolon in ie_imp_KWord_1.cpp
- ie_imp_WordPerfect.cpp uses an invalid preprocessor directive
("#ABI_PLUGIN_DECLARE")
- ie_imp_WordPerfect.cpp doesn't declare m_sniffer, but uses it
All those are fixed by attachment #4.
Lastly, the Makefiles are broken.
/usr/src/redhat/BUILD/abiword-0.9.4.1/abi/src/Linux_2.4.12-0.3_i386_GTK_XML/obj/libAbiImpExp.a(ie_exp_Applix.o):
In function `abi_plugin_register':
ie_exp_Applix.o(.text+0x0): multiple definition of `abi_plugin_register'
/usr/src/redhat/BUILD/abiword-0.9.4.1/abi/src/Linux_2.4.12-0.3_i386_GTK_XML/obj/libAbiImpExp.a(ie_exp_AWT.o)(.text+0x0):
first defined here
/usr/src/redhat/BUILD/abiword-0.9.4.1/abi/src/Linux_2.4.12-0.3_i386_GTK_XML/obj/libAbiImpExp.a(ie_exp_Applix.o):
In function `abi_plugin_unregister':
ie_exp_Applix.o(.text+0xa0): multiple definition of
`abi_plugin_unregister'
[... Loads of the same for every plugin ...]
I don't presume the lib should be built at all if they're plugins?
I haven't done anything to fix this (I don't know anything about the way
abiword's build system works).
This is using the tarballs from
http://prdownloads.sourceforge.net/abiword/ (the download link on
abisource.com still lists 0.7.4 as current) - is this a random CVS
snapshot someone is pushing out as a release, or did nobody try those
options?
LLaP
bero
This archive was generated by hypermail 2b25 : Tue Oct 23 2001 - 10:52:16 CDT