Commit + Request for favor

From: Dom Lachowicz (doml@appligent.com)
Date: Fri May 24 2002 - 11:24:17 EDT

  • Next message: Karl Ove Hufthammer: "Re: Font, layout units et al."

    Hi Tomas and others,

    1) Commit - remove as many wchar_t's as is humanly possible. A few still
    linger in platform-specific places. Also remove dead branches of code
    from wctomb and mbtowc functions. Files are now actually humanly
    readable.

    2) Commit + Request

    At least on RH7.3 Linux (and Mike Pritchett hits something similar on
    win32), I run into a problem when I select text to copy. My particular
    asserts are:

    **** (1) Assert ****
    **** (1) UT_NOT_REACHED at
    ../../../../../abi/src/wp/impexp/xp/ie_exp_Text.cpp:350 ****
    **** (1) Continue ? (y/n) [y] :

    **** (2) Assert ****
    **** (2) m_iLineBreakLen && m_iLineBreakLen < 20 at
    ../../../../../abi/src/wp/impexp/xp/ie_exp_Text.cpp:355 ****
    **** (2) Continue ? (y/n) [y] :

    If I continue, and then "Paste Unformatted", I end up pasting back
    "?????????" instead of my intended text. MPritchett gets an error at
    line 394 I think.

    Both of these deal with _wctomb, so this looks like something that you
    could probably fix. I've fixed wctomb.cpp by making it open UCS_INTERNAL
    instead of UCS-2, and fixed the wctomb method to make it use UT_UCS4Char
    buffers and I *think* handle all 4 bytes from the UT_UCS4Char instead of
    only 2. In any event, select, copy, and paste works again for me, and
    that's all this en-US person cares about for the moment. I'd appreciate
    if you could look into my changes and see if I've fouled up anything. In
    any event, things are less-fouled than they were a few minutes ago as I
    no longer get the asserts + select/cut/copy/paste works again.

    Thanks in advance,
    Dom

    CVS:
    ----------------------------------------------------------------------
    CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
    CVS:
    CVS: Committing in .
    CVS:
    CVS: Modified Files:
    CVS: src/af/gr/unix/gr_UnixGraphics.cpp src/af/util/xp/ut_iconv.cpp
    CVS: src/af/util/xp/ut_mbtowc.cpp src/af/util/xp/ut_mbtowc.h
    CVS: src/af/util/xp/ut_wctomb.cpp src/af/util/xp/ut_wctomb.h
    CVS: src/af/xap/xp/xap_Strings.cpp src/wp/impexp/xp/ie_exp_Text.cpp
    CVS: src/wp/impexp/xp/ie_exp_Text.h
    CVS:
    ----------------------------------------------------------------------


    This archive was generated by hypermail 2.1.4 : Fri May 24 2002 - 11:29:55 EDT