From: Patrick Lam (plam@plam.lcs.mit.edu)
Date: Sat May 25 2002 - 23:23:49 EDT
major privatization push centred in fp_Run.cpp
CVS: ----------------------------------------------------------------------
CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
CVS:
CVS: Committing in .
CVS:
CVS: Modified Files:
CVS: src/af/util/xp/ut_misc.cpp src/af/util/xp/ut_misc.h
CVS: src/text/fmt/xp/fl_Layout.h
CVS: src/text/fmt/xp/fl_SectionLayout.cpp
CVS: src/text/fmt/xp/fp_FieldListLabelRun.cpp
CVS: src/text/fmt/xp/fp_FmtMarkRun.cpp src/text/fmt/xp/fp_Line.cpp
CVS: src/text/fmt/xp/fp_Run.cpp src/text/fmt/xp/fp_Run.h
CVS: src/text/fmt/xp/fp_TestRoutines.cpp
CVS: src/text/fmt/xp/fp_TextRun.cpp src/text/fmt/xp/fp_TextRun.h
CVS: src/text/fmt/xp/fv_View.cpp src/text/ptbl/xp/pt_VarSet.cpp
CVS: src/wp/ap/xp/ap_Dialog_ListRevisions.cpp
CVS: src/wp/impexp/xp/ie_exp_RTF.cpp
CVS: src/wp/impexp/xp/ie_exp_RTF_listenerWriteDoc.cpp
CVS: src/wp/impexp/xp/ie_imp_XML.cpp
CVS: ----------------------------------------------------------------------
I eliminated all protected data in fp_Run and replaced it by private
data. You have to use accessor methods now.
I instituted the convention that _setFOO() will just set the data,
whereas setFOO() may have some side effect (clearing the screen, for
instance). setFOO() may not always exist (so that's kind of lame).
The same convention applies to _getFOO() vs getFOO().
This helped me track down a bug the other day with justified text and
printing, for instance; I expect it to be helpful with other bugs as
well. Compilers should be able to inline away _getFOO() and replace
the call by an inline access.
Perhaps I went too far in making m_pGR be accessed by functions only;
we might want to undo that particular field.
pat
This archive was generated by hypermail 2.1.4 : Sat May 25 2002 - 23:29:36 EDT