commit: another endnote undo fix

From: Patrick Lam (plam@plam.lcs.mit.edu)
Date: Thu May 30 2002 - 01:58:39 EDT

  • Next message: F J Franklin: "Re: Still can't build HEAD"

    endnote undo fix
    CVS: ----------------------------------------------------------------------
    CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
    CVS:
    CVS: Committing in .
    CVS:
    CVS: Modified Files:
    CVS: src/text/fmt/xp/fl_BlockLayout.cpp
    CVS: src/text/fmt/xp/fl_SectionLayout.cpp
    CVS: src/text/fmt/xp/fv_View.cpp
    CVS: src/text/fmt/xp/fv_View_protected.cpp
    CVS: src/text/ptbl/xp/pf_Fragments.cpp
    CVS: src/text/ptbl/xp/pt_PT_ChangeSpan.cpp
    CVS: src/text/ptbl/xp/pt_PT_DeleteSpan.cpp
    CVS: src/text/ptbl/xp/pt_PT_DeleteStrux.cpp
    CVS: src/text/ptbl/xp/pt_PieceTable.h
    CVS: ----------------------------------------------------------------------

    Dom found another endnote undo bug to do with the ruler. I think I've
    got this one fixed too.

    I found this mysteriously commented code in fl_SectionLayout:

    @@ -1579,11 +1605,11 @@
             m_pLayout->removeSection(this);
             pPrevSL->format();
     
    -// FV_View* pView = m_pLayout->getView();
    -// if (pView)
    -// {
    -// pView->_setPoint(pcrx->getPosition());
    -// }
    + FV_View* pView = m_pLayout->getView();
    + if (pView)
    + {
    + pView->_setPoint(pcrx->getPosition());
    + }

    The key to fixing this bug was enabling this code; anyone have any
    idea why it was commented?

    I am aware of at least one more endnote bug: you can't insert
    an endnote into a document already having endnotes if the endnote would
    be first. I'll look into it tomorrow.

    pat



    This archive was generated by hypermail 2.1.4 : Thu May 30 2002 - 02:04:35 EDT