Re: getProperties() error ?

> > pLayout->getAttrProp(&pAP, pRevisions, bShowRevisions, iId,
> > bHiddenRevision);
> > DELETEP(pRevisions); // we don't need it
>
> Never do this! The properties vector points to allocated memory that is
> only deleted when the whole piecetable is delted. You get bitten by this
> later.

Erm, this is all over our codebase ... in fact, fl_Layout::getAttrProp
even _tells_ me to do it!

> > UT_return_if_fail(pAP);
> >
>
> Looks like pAP->getProperties() has a pointer to the same class as
> pRevisions. When you delete one you invalidate the other. Get rid of the
> DELETEP(pRevisions) line.
>
> Why do you want it anyway?

Want what? delete pRevisions ? since I do't need it, and fl_Layout::getAttrProp tells me I'm allowed to delete it.

Now, with or without de DELETEP, the error is still the same.

Marc
Received on Sun Jul 11 02:40:33 2004