On 07/26/2009 02:06 AM, cvs@abisource.com wrote:
> + else if(nameMatches(rqst->pName, NS_W_KEY, "shd"))
> + {
> + std::string contextTag = rqst->context->back();
> + rqst->handled = contextMatches(contextTag, NS_W_KEY, "tcPr") || contextMatches(contextTag, NS_W_KEY, "tblPr");
> + }
Also this is a situation where rqst->context->back() return a const ref.
So I would change
std::string contextTag = rqst->context->back();
with
const std::string & contextTag = rqst->context->back();
Even if std::string is copy on write (as an implementation detail), this
is IMHO better: reference and proper constness.
There are probably other places where this can be addressed.
Hub
Received on Sun Jul 26 09:38:18 2009
This archive was generated by hypermail 2.1.8 : Sun Jul 26 2009 - 09:38:18 CEST