Re: RDF UI support

The test should be in the with-champlain test. At the moment, if you
have libchamplain and configure --without-champlain, you end using
champlain, and after configure --with-champlain build just fails.
The only sane case is when you don't have any champlain related arg.
I probably should patch this myself ;-)

Regards,
Jean

Le lundi 13 février 2012 à 12:53 +1000, Ben Martin a écrit :
> Hi,
> In configure.in I have a test for champlain-gtk-0.12.
>
> looking at configure.in I see a check with the following fragment:
>
> champlain_req=' champlain-gtk-0.12 '
> ...
> PKG_CHECK_MODULES(CHAMPLAIN, [ $champlain_req ],
>
> In src/Makefile.am I link with CHAMPLAIN if it is found in the
> libabiword_@ABIWORD_SERIES@_la_LDFLAGS target.
>
> I'm not sure which changes are needed to better detect and optionally
> use champlain if found. I'm happy to make any needed changes.
>
>
> On Sun, 2012-02-12 at 08:50 +0100, Jean Brefort wrote:
> > Also, if abiword is configured with --wih-champlain, build fails because
> > CFLAGS and LIBS are not correctly set in that case. We need to add an
> > appropriate call to pkg-config.
> >
> > Regards,
> > Jean
> >
> > Le samedi 11 février 2012 à 13:38 -0800, Hub Figuière a écrit :
> > >
> > > >> Here is the issues:
> > > >>
> > > >> - The ap_EditMethods are compiled in even when RDF support isn't. BAD
> > > >>
> > > >> - runInsertReferenceDialog() and runSemanticStylesheetsDialog() are
> > > >> implemented in src/text/ptbl/xp/pd_DocumentRDF.cpp which isn't compiled
> > > >> when RDF support isn't. GOOD
> > > >>
> > > >> - these two function don't belong in pd_DocumentRDF.cpp. UI do NOT
> > > >> beling the PD_*. Gtk code do not belong to "xp" code. BAD and BAD.
> > > >
> > > > Yep. I'll fix this shortly, using the more complex method below.
> > >
> > > Also, the patch dragging libchamplain into AbiWord break the build on
> > > Gtk2 as libchamplain bring Gtk-whatever with it.
> > >
> > > I'm not sure what the proper solution is.
> > >
> > > Hub
> >
> >
> >
>
Received on Mon Feb 13 08:51:12 2012