commit -- was Re: [patch] Fix for bug #342
Paul Rohr (paul@abisource.com)
Tue, 04 May 1999 12:02:32 -0700
At 08:36 PM 5/1/99 -0600, Matt Kimball wrote:
>Ok, it took a lot more effort than I thought it would, but I got
>revert to work when you have multiple views of the same document open.
>As a side effect, I implemented reference counting in XAD_Document,
>along with two new macros -- REFP and UNREFP -- for managing
>references on reference-counted object. So -- now that XAD_Document
>is reference counted, the memory management of XAD_Document's is much
>nicer when there are multiple frames with the same document.
>
>The rest of the patch has to do with making sure all frames with refer
>to a particular document object are changed to a new document object
>when a document is reverted to its on-disk version. To do this, I had
>to patch platform-specific code. I've patches all three versions --
>Unix, BeOS and Win32 -- but I've only tested the Unix version. Sorry,
>I've got only Linux installed on my home machine at the moment. The
>other two should work fine, but, like I said, they're untested.
>
>The patch is attached.
Applied patch from Matt Kimball <robozapp@xmission.com> to allow revert on
document with multiple views. Fixes #342.
M src/af/util/xp/ut_types.h
M src/af/util/xp/ut_vector.cpp
M src/af/util/xp/ut_vector.h
M src/af/xap/xp/xad_Document.cpp
M src/af/xap/xp/xad_Document.h
M src/af/xap/xp/xap_App.cpp
M src/af/xap/xp/xap_App.h
M src/af/xap/xp/xap_Frame.cpp
M src/text/ptbl/xp/pd_Document.h
M src/wp/ap/beos/ap_BeOSFrame.cpp
M src/wp/ap/beos/ap_BeOSFrame.h
M src/wp/ap/unix/ap_UnixFrame.cpp
M src/wp/ap/unix/ap_UnixFrame.h
M src/wp/ap/win/ap_Win32Frame.cpp
M src/wp/ap/win/ap_Win32Frame.h
A full rebuild is recommended.
Paul
PS: John, this patch did not get applied to ap_MacFrame.{h,cpp} because your
implementation was so minimal. Was there a reason your stub was so
incomplete?
This archive was generated by hypermail 1.03b2.