Re: Inserted image size

Eric W. Sink (eric@postman.abisource.com)
Wed, 26 May 1999 09:50:48 -0500


In general, I think images should be inserted at approximately
screen resolution. Most images are in fact at approximately that
resolution anyway.

Images which are way too big should probably be automatically scaled
down to something which will fit in the document page. Resize handles
will be necessary.

However, the real fix for bug 417 is to simply ignore the zoom
factor when inserting an image. Image insert was coded before zoom,
and it was designed to simply assume screen resolution when inserting
the image. Unfortunately, the zoom code worked too well, altering
the notion of screen resolution from the image insertion code's
point of view. We can simply special-case that one, and bug 417
will go away.

This will not address the real problems being raised on this thread,
but it will effect the original [arguably broken] behavior which
was intended.

--

> Ok, so I've been thinking about bug #417, and how it might be fixed, > but I'm not exactly sure what the correct behavior is. For those who > can't be bothered to look in Bugzilla, the problem is that when you > insert an image, the image is sized such that at the current zoom > level, you get pixel-for-pixel sizing. That means that the size of > the image on paper depends on your zoom setting when you insert it. > > The first-order fix is to look at the pHYs section in the PNG and get > the physical resolution from that, and use it. This is great, but > lots and lots of PNGs don't have any physical resolution information. > So the problem remains that there is no one correct size for those > images. Should AbiWord assume 72 dpi on those images? Should it > always insert images at a specific size -- say 1 inch wide? Should it > guess at a size based on the resolution of the image and the paper > width and use something that isn't absurdly big or small? > > I think whichever option is chosen, there still needs to be some way > to resize without editing the XML, so there should be handles or > something on the image. > > Thoughts? > > -- > Matt Kimball > mkimball@xmission.com

-- 
Eric W. Sink, Software Craftsman
eric@abisource.com


This archive was generated by hypermail 1.03b2.